Problem report by location - PicInfo sample application

PicForm.frm

  1 Form missing Icon
  1 Control outside visible area: CommandButton SaveFile - Too far right

Sub PicForm.Form_KeyPress

    Dead procedure - KeyPreview property is False

PicMain.bas


Function PicMain.GetSaveFileNameA

    Dead declaration
18 Too many uncommented lines: 24

PicMain.(declarations)

44 Dead enum constant: OFN_ALLOWMULTISELECT
45 Dead enum constant: OFN_CREATEPROMPT
49 Dead enum constant: OFN_NOCHANGEDIR
54 Dead enum constant: OFN_NODEREFERENCELINKS
57 Dead enum constant: OFN_NONETWORKBUTTON
64 Dead enum constant: OFN_NOTESTFILECREATE
76 Dead enum constant: OFN_READONLY
80 Dead enum constant: OFN_SHAREAWARE
92 Dead enum constant: OFN_SAVEDEFAULTS

Function PicMain.ShowFileOpenDialog

    Too many parameters: ShowFileOpenDialog

Function PicMain.FileDialog

    Too many parameters: FileDialog
190 Too many uncommented lines: 34

PicBMP.cls


PicBMP.(declarations)

21 Type field written, not read: bfSize - 0 reads, 1 write
24 Type field written, not read: bfOffBits - 0 reads, 1 write
25 Too many uncommented lines: 27

PicBMP.(declarations)

27 Type field written, not read: biSize - 0 reads, 1 write
30 Type field written, not read: biPlanes - 0 reads, 1 write
33 Type field written, not read: biSizeImage - 0 reads, 1 write
34 Type field written, not read: biXPelsPerMeter - 0 reads, 1 write
35 Type field written, not read: biYPelsPerMeter - 0 reads, 1 write
36 Type field written, not read: biClrUsed - 0 reads, 1 write
37 Type field written, not read: biClrImportant - 0 reads, 1 write
40 Type field written, not read: bcSize - 0 reads, 1 write
43 Type field written, not read: bcPlanes - 0 reads, 1 write
49 Dead constant: BI_RGB
52 Dead constant: BI_bitfields
57 Variable written, not read: IsRLE - 0 reads, 2 writes
60 Variable read, not written: StoredFilename - 1 read, 0 writes

Function PicBMP.ReadBitmapFile

85 Consider short circuit with nested Ifs

PicGIF.cls


PicGIF.(declarations)

31 Type field written, not read: BackgroundColorIndex - 0 reads, 1 write
32 Type field written, not read: PixelAspectRatio - 0 reads, 1 write

Property PicGIF.Version [Get]

    Dead procedure

Number of problems by file

File Problems  
PicBMP.cls 17 *********
PicMain.bas 14 ********
PicForm.frm 3 **
PicGIF.cls 3 **


Problem statistics

Problem Count Type
Consider short-circuited logic 1 Opt
Control outside visible area 1 Dead
Dead constant 2 Dead
Dead enum constant 9 Dead
Dead procedure/declaration/event 3 Dead
Form missing Icon 1 Func
Too many parameters 2 Style
Too many uncommented lines 3 Style
Type field written, not read 13 Dead
Variable read, not written 1 Dead
Variable written, not read 1 Dead
   
Type Count
Optimization 1
Style 5
Functionality 1
Dead 30
===== =====
Total 37
Problems/logical code line 0,10

Filter: <Default>