Project Analyzer

Problem report by location – PicInfo sample application

PicBMP

21 Type field written, not read: BITMAPFILEHEADER.bfSize - 0 reads, 1 write
24 Type field written, not read: BITMAPFILEHEADER.bfOffBits - 0 reads, 1 write
25 Too many uncommented lines: 27
27 Type field written, not read: BITMAPINFOHEADER.biSize - 0 reads, 1 write
30 Type field written, not read: BITMAPINFOHEADER.biPlanes - 0 reads, 1 write
33 Type field written, not read: BITMAPINFOHEADER.biSizeImage - 0 reads, 1 write
34 Type field written, not read: BITMAPINFOHEADER.biXPelsPerMeter - 0 reads, 1 write
35 Type field written, not read: BITMAPINFOHEADER.biYPelsPerMeter - 0 reads, 1 write
36 Type field written, not read: BITMAPINFOHEADER.biClrUsed - 0 reads, 1 write
37 Type field written, not read: BITMAPINFOHEADER.biClrImportant - 0 reads, 1 write
40 Type field written, not read: BITMAPCOREHEADER.bcSize - 0 reads, 1 write
43 Type field written, not read: BITMAPCOREHEADER.bcPlanes - 0 reads, 1 write
49 Dead constant: BI_RGB
52 Dead constant: BI_bitfields
57 Variable written, not read: IsRLE - 0 reads, 2 writes
60 Variable read, not written: StoredFilename - 1 read, 0 writes

Property IPicInfo_MaxColors [Get]

128 Case branch(es) missing for Enum - bmpUnknown

Property IPicInfo_Size [Get]

153 Case branch(es) missing for Enum - bmpUnknown

PicForm

1 Form missing Icon
1 Control outside visible area: CommandButton SaveFile - Too far right

Sub Form_KeyPress

Dead procedure - KeyPreview property is False
49 Possibly commented-out code

PicGIF

31 Type field written, not read: TLogicalScreenDescriptor.BackgroundColorIndex - 0 reads, 1 write
32 Type field written, not read: TLogicalScreenDescriptor.PixelAspectRatio - 0 reads, 1 write

Function ReadGIF

90 Assigned value not used: FileNr - Integer

Property Version [Get]

Dead procedure

PicMain

Declare Function GetSaveFileNameA

Dead declaration
044 Dead enum constant: OFN_ALLOWMULTISELECT
045 Dead enum constant: OFN_CREATEPROMPT
045 Line too long: 181
049 Dead enum constant: OFN_NOCHANGEDIR
054 Dead enum constant: OFN_NODEREFERENCELINKS
057 Dead enum constant: OFN_NONETWORKBUTTON
064 Dead enum constant: OFN_NOTESTFILECREATE
076 Dead enum constant: OFN_READONLY
080 Dead enum constant: OFN_SHAREAWARE
092 Dead enum constant: OFN_SAVEDEFAULTS

Function ShowFileOpenDialog

Too many parameters: ShowFileOpenDialog
117 Line too long: 296
Optional parameter never passed a value: DialogTitle
Optional parameter never passed a value: InitialDir
Optional parameter never passed a value: Flags
Optional parameter never passed a value: FilterIndex

Function FileDialog

Too many parameters: FileDialog
135 Line too long: 234
190 Too many uncommented lines: 34

Number of problems by file

File Problems Distribution
PicMain 20 ********************
PicBMP 18 ******************
PicGIF 4 ****
PicForm 4 ****


Problem statistics

Problem Count Type
Assigned value not used 1 Logic
Case branch(es) missing for Enum 2 Logic
Control outside visible area 1 Dead
Dead constant 2 Dead
Dead enum constant 9 Dead
Dead procedure/declaration/event 3 Dead
Form missing Icon 1 Func
Line too long 3 Style
Optional parameter never passed a value 4 Dead
Possibly commented-out code 1 Style
Too many parameters 2 Style
Too many uncommented lines 2 Style
Type field written, not read 13 Dead
Variable read, not written 1 Dead
Variable written, not read 1 Dead
     
Type Count  
Style 8  
Functionality 1  
Logic 3  
Dead code 34  
Total 46  
Problems/logical code line 0,12  

Filter: <Default>